ci: Added a clang++15 osx job, fixed clang++14 job. #1204
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
github_actions
braindigitalis
approved these changes
Jul 18, 2024
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our OSX runner to have
clang++14andclang++15jobs, instead of onlyclang++14. This PR also fixes theclang++14job, where it was actuallyclang++15.The
clang++15job is using Xcode 15.3 to ensure thatstd::formatis tested (as versions below don't havestd::format), however, it should be noted that we NEED to enforce checks forstd::formatfeatures to prevent Xcode 15.2 and lower versions breaking, otherwise we will be heavily breaking OSX support.